search

ckan / ckanext-dcat

CKAN ♥ DCAT
https://docs.ckan.org/projects/ckanext-dcat
165 stars 145 forks source link

Make read keywords re-usable #160

Closed seitenbau-govdata closed 5 years ago

seitenbau-govdata commented 5 years ago
seitenbau-govdata commented 5 years ago

@metaodi and @amercader ,

has one of you some time to review, please? It was only a small re-factoring (moving code) in one file. Thanks in advance.

seitenbau-govdata commented 5 years ago

@metaodi and @amercader ,

we also need a new release of the plugin. 😊 And would it be possible to have regular releases? It makes the release of our plugins and the usage by other parties much more easier if we can point to a official release in the requirements.txt instead using self created enriched installation packages. If you have no time (as I assume) we could help and have a look at this and release new version from time to time. 😉

metaodi commented 5 years ago

@seitenbau-govdata merged, thanks for this refactoring. I agree on having regular releases, that's why I maintain the CHANGELOG file. I'm currently on vacation, so I could only create a release next week. I guess it would be no problem for you to become maintainers as well. Since this is @amercader's baby, he should decide.

seitenbau-govdata commented 5 years ago

@metaodi Many thanks for merging it so fast and this either in your vacation. 😮 I think you know that you really don't have to do this. Anyway I'm happy that I can tick off the point in our to-do list now. 😄 But I hope you will enjoy your remaining holidays. 🌅 Cheers.

metaodi commented 5 years ago

@seitenbau-govdata don't worry, all good here 😎

amercader commented 5 years ago

@seitenbau-govdata how do you feel about becoming a maintainer as @metaodi suggested? You are obviously heavy users of the extension and have contributed regularly to it.

This is a pretty mature extension so there won't be a huge workload attached and you could help review incoming PRs and make releases if needed.

No pressure, just let me know if you are interested

seitenbau-govdata commented 5 years ago

@amercader Yes, it's fine for me. Do I have to know something special before starting with the work, such as before doing a merge or release a new version?

metaodi commented 5 years ago

@seitenbau-govdata I noted down the steps to do a release in the README: https://github.com/ckan/ckanext-dcat#releases

seitenbau-govdata commented 5 years ago

@metaodi Great! Thanks a lot for that. This is very useful!

seitenbau-govdata commented 4 years ago

@seitenbau-govdata how do you feel about becoming a maintainer as @metaodi suggested? You are obviously heavy users of the extension and have contributed regularly to it.

This is a pretty mature extension so there won't be a huge workload attached and you could help review incoming PRs and make releases if needed.

No pressure, just let me know if you are interested

@amercader We're ready if you are. 😃

amercader commented 4 years ago

@seitenbau-govdata sorry sorry sorry I was meaning to do this ages ago and totally slipped my mind. Can you send me an email (amercadero at Gmail.com)? Just want to check one thing. Thanks!

seitenbau-govdata commented 4 years ago

@amercader No problem. You have an e-mail.