search

ckan / ckanext-dcat

CKAN ♥ DCAT
164 stars 142 forks source link

Fix format normalization configuration #175

Closed seitenbau-govdata closed 4 years ago

seitenbau-govdata commented 4 years ago

We wanted to deactivate the ckan format normalization by config. But we are surprised that the config parameter ckanext.dcat.normalize_ckan_format seems to be ignored. We invested some time and found out the reason. The reason is that the config parameter was read from the config file but was interpreted as string what is still the default behavior for an ini file. So, the value False in the config file was interpreted as string 'False' and not as boolean what will lead to the situation that the expression and normalize_ckan_format was always True, because a not empty string is interpreted as True.

The pull request adds the conversion of the param to type boolean.

seitenbau-govdata commented 4 years ago

@amercader or @metaodi Maybe one of you will find time to have a look at this PR? Thanks in advance!