Update ckan hooks for CKAN 2.10 support

ckan / ckanext-dcat

CKAN ♥ DCAT

164 stars 142 forks source link

Update ckan hooks for CKAN 2.10 support #241

Closed seitenbau-govdata closed 1 year ago

seitenbau-govdata commented 1 year ago

@amercader The tests for CKAN < 2.9 and with Python 2 are now broken after merging https://github.com/ckan/ckanext-harvest/pull/520 in ckanext-harvest. I assume that the tests on the master are also broken. So the changes in the pull request are independent from the failing tests.

Is there a plan to update the ckanext-dcat according to https://github.com/ckan/ckanext-harvest/pull/520 in ckanext-harvest?

pdelboca commented 1 year ago

@seitenbau-govdata We no longer support PY2 nor versions lower than 2.9. It's in our "to-do list" to clean up this extension but currently our availability is limited.

Do you have time to drop the support for old versions in this extension? I would happily review and assist you in the process

Basically:

[ ] Remove PY2 compatibility: six, requirements files and ifelses in the code
[ ] Clean commands
[ ] Clean controllers
[ ] Clean Github actions
[ ] Clean paster command from setup.py

seitenbau-govdata commented 1 year ago

@pdelboca Ok. We'll try to make the necessary changes in a new PR.

seitenbau-govdata commented 1 year ago

@pdelboca and @amercader If you agree, we would like to merge the pull request as a base for https://github.com/ckan/ckanext-dcat/pull/244, because here the translation tests fail.