ckan / ckanext-dcat

CKAN ♥ DCAT
https://docs.ckan.org/projects/ckanext-dcat
168 stars 148 forks source link

feat: add has_version to default schema #306

Closed hcvdwerf closed 1 month ago

hcvdwerf commented 2 months ago

Missing has_version in full default example schema

amercader commented 1 month ago

@hcvdwerf Add this to make the failures go away:

diff --git a/ckanext/dcat/schemas/dcat_ap_full.yaml b/ckanext/dcat/schemas/dcat_ap_full.yaml
index fc89c0a..eea83b2 100644
--- a/ckanext/dcat/schemas/dcat_ap_full.yaml
+++ b/ckanext/dcat/schemas/dcat_ap_full.yaml
@@ -314,6 +314,7 @@ resource_fields:
 - field_name: has_version
   label: Has version
   preset: multiple_text
+  validators: ignore_missing scheming_multiple_text
   help_inline: true
   help_text: This property refers to a related Dataset that is a version, edition, or adaptation of the described Dataset.
hcvdwerf commented 1 month ago

@hcvdwerf Add this to make the failures go away:

diff --git a/ckanext/dcat/schemas/dcat_ap_full.yaml b/ckanext/dcat/schemas/dcat_ap_full.yaml
index fc89c0a..eea83b2 100644
--- a/ckanext/dcat/schemas/dcat_ap_full.yaml
+++ b/ckanext/dcat/schemas/dcat_ap_full.yaml
@@ -314,6 +314,7 @@ resource_fields:
 - field_name: has_version
   label: Has version
   preset: multiple_text
+  validators: ignore_missing scheming_multiple_text
   help_inline: true
   help_text: This property refers to a related Dataset that is a version, edition, or adaptation of the described Dataset.

@amercader Thanks for the comment. This fix resolves the issue with the failing unit tests.