search

ckan / ckanext-dcat

CKAN ♥ DCAT
https://docs.ckan.org/projects/ckanext-dcat
165 stars 145 forks source link

Removing IPackageController code #90

Closed thriuin closed 7 years ago

thriuin commented 7 years ago

Removing code that does not appear to be used and is interfering with rendering the read package page on our web site at open.canada.ca

thriuin commented 7 years ago

Ah, @wardi there tests for the controllers so will need some feedback from the original authors if it is still OK to remove this code and its accompanying tests.

wardi commented 7 years ago

interesting that it only fails on more recent ckan versions. @amercader the after_show code is interfering with our custom schema (we have a language field at the resource level) do you know why it's implemented this way and not with a helper and an overridden resource template?

amercader commented 7 years ago

@wardi as this is a "generic" extension I didn't want to override the templates as users might have already done so, but if necessary I'm willing to consider it.

In theory after_show hooks are called in succession so if your extension if loaded after dcat can you not modify the data_dict according to your needs?

wardi commented 7 years ago

@amercader this PR was supposed to only include 5ababd0 we can open a new one.

thriuin commented 7 years ago

Ah, my bad, I merged in those last 2 commits yesterday - they shouldn't be there.