Closed insertjokehere closed 7 years ago
:+1:
Should this be a 2.1.1 release then? Non-breaking new feature introduced + bug fix.
In that case we will end up with v3 too soon. Currently there is small stack of issues and one interesting pull request(unfortunately, without descrtiption, but this change will be quite useful after work finished), so let's at least wait for few more additions
Setting a googleanalytics_fields key to
True
as in #25 causes the resulting Javascript to also include the literalTrue
, which is not valid. This works around that by setting the key to'true'
which when evaluated in an if statement is truthy, serving the same purposeI also tried using
{{h.dump_json(googleanalytics_fields)|safe}}
and loading that in usingJSON.parse
, buth.dump_json
seems to return invalid JSON when used in a template