Closed cuducos closed 3 years ago
It's just common practice in CKAN project to use requirements file instead of pinning requirements using install_requires
. Mainly it's done in order to avoid situations when you unable to install a particular set of extensions\packages because of conflicting requirements - you always have a chance to solve conflict manually
But I think it's ok to use extras_require
instead, so that you'll be able to use something like pip install -e .[requirements]
Ow, got it! Many thanks, @smotornyuk!
Hi there,
Is there a specific reason for keeping the dependencies of this Python package in a
requirements.txt
file and not in theinstall_requires=[]
part of thesetup.py
?The way this project is made ignores
requirements.txt
duringpip install -e <repo>
, making it mandatory to do an extrapip install -r requirements.txt
. If we useinstall_requires
, all dependencies would be handled duringpip install -e <repo>
, simplifying the installation steps.I would like to have everything handles by
pip
and I can open a PR.Also, if you think this way is interesting for the project, I can drop both
requirements.txt
andsetup.py
adopting the PEP 517'spyproject.toml
, which would give even more flexibility with tools like Poetry (such as dependencies and development dependencies). Any thoughts?