search

ckan / ckanext-googleanalytics

CKAN extension to integrate Google Analytics data into CKAN. Gives download stats on package pages, list of most popular packages, etc.
GNU Affero General Public License v3.0
35 stars 81 forks source link

Broken compatibility with python 2.7 #66

Closed ccancellieri closed 2 years ago

ccancellieri commented 2 years ago

Hi guys, looks like it's impossible to install this plugin (from master branch) over python 2.7:

bash-5.1# python setup.py develop Traceback (most recent call last): File "setup.py", line 16, in with open(os.path.join(HERE, 'README.md'), encoding='utf-8') as f: TypeError: 'encoding' is an invalid keyword argument for this function

The above open(..., encoding) looks not supported on python2.7 This is my last working upgrade: 3e620b574a9d75bfd5d88740cbf84d1ebe3172f9

frafra commented 2 years ago

Similar issue: https://github.com/ckan/ckan/pull/6532

Zharktas commented 2 years ago

This extensions would benefit from CI integration like some other extensions have, those catch most of the errors.

smotornyuk commented 2 years ago

I've added py2 compatible open[encoding]