search

ckan / ckanext-harvest

Remote harvesting extension for CKAN
130 stars 203 forks source link

Fix checking for harvest objects in fetch queue. #421

Closed bellisk closed 4 years ago

bellisk commented 4 years ago

The fetch queue is stored in redis as a list of harvest object ids. The previous code checked for individual harvest object ids in redis, and always found none. Therefore, every time the harvester run command was run, all ids of harvest objects in the WAITING state in the DB were re-added to the fetch queue.

Fixes #420.

amercader commented 4 years ago

Thanks a lot @bellisk , this was a bit embarrassing on my side, thanks for spotting it. I just added a minor suggestion, if you can make the change I'll merge and release a new version as this is quite bad

bellisk commented 4 years ago

Ready to merge, @amercader. :) Thanks for looking at it so quickly.

amercader commented 4 years ago

I've just release 1.3.2 including this fix, thanks again @bellisk !