ckan / ckanext-harvest

Remote harvesting extension for CKAN
130 stars 203 forks source link

Fix harvest extras for packages #458

Closed jbrown-xentity closed 2 years ago

jbrown-xentity commented 2 years ago

It seems that injecting the harvest extra information at search/show time is very complex. We (US data.gov CKAN team) propose a solution that puts the extra objects into the package itself, and remove the complex necessary code.

This was raised to our attention when we discovered that we had bad data from harvesting another CKAN source, and when the harvest information was no longer displayed when using package_show, only on package_search (which hurt our API users). See example package_search vs package_show

This replaces https://github.com/ckan/ckanext-harvest/pull/438, as our team member Chris has moved onto another project.

@amercader, any possibility we could merge this?

jbrown-xentity commented 2 years ago

Passing tests (in case they don't get run here): https://github.com/GSA/ckanext-harvest/actions/runs/1254660702

jbrown-xentity commented 2 years ago

@amercader ping

amercader commented 2 years ago

Many thanks @jbrown-xentity , this is a much simpler implementation