ckan / ckanext-harvest

Remote harvesting extension for CKAN
130 stars 203 forks source link

No organization available: form error without any relevant field #471

Open frafra opened 3 years ago

frafra commented 3 years ago

When there are no organizations defined and a harvest source is created, the forms gives an error, because no organization has been selected. I think this message is confusing, as there is no field for selecting such organization.

I would suggest showing a message if no organization is defined before submitting the form.

https://github.com/ckan/ckanext-harvest/blob/2910693571c48d7f9d0e5feff4731cce7e26d640/ckanext/harvest/templates/source/new_source_form.html#L61-L78

Instead of having only an if, an else could be created, with a link to define an organization, or some kind of help text. An empty readonly selector could also be shown.