search

ckan / ckanext-harvest

Remote harvesting extension for CKAN
130 stars 203 forks source link

Futureproof version check to work also on 3.0+ #487

Closed Zharktas closed 2 years ago

Zharktas commented 2 years ago

Coworker of mine noticed that version check would fail when the ckan version 3.0 is released as the minor version is no longer greater than 9, this updated check will also work on 3.0 and any patch releases which can be defined in the check.

amercader commented 2 years ago

This check should really be provided by a core / toolkit helper but of course this is a good patch in the meantime

ThrawnCA commented 2 years ago

Several templates were overlooked (found by searching the repository for "h.ckan_version"):

ckanext/harvest/templates/snippets/source_item.html ckanext/harvest/templates/source/read_base.html ckanext/harvest/templates/source/source_item.html ckanext/harvest/templates/source/admin_base.html