ckan / ckanext-harvest

Remote harvesting extension for CKAN
130 stars 203 forks source link

added unescape for email text body to avoid encoded characters #517

Closed Jin-Sun-tts closed 1 year ago

Jin-Sun-tts commented 1 year ago

The harvest report emails sent to users contains encoded characters, like ' and "

This makes it hard for users to understand the error message. For example:

before ERROR #1: 'description':'' is too short.

after ERROR #1: 'description':'' is too short.

jbrown-xentity commented 1 year ago

cc @amercader @avdata99 , this is due to data.gov email formatting problems.

avdata99 commented 1 year ago

@jbrown-xentity , I think it's good for Python 3 but we need to cover Python 2 users (CKAN <= 2.9-py2) users html.unescape is only available from Python 3.4 Tests for this extension still check from CKAN 2.7

Check your GitHub actions:

image

jbrown-xentity commented 1 year ago

Thanks @avdata99 , we'll push something with six handling the Py2 use case... Any reason why the checks don't show up on the PR? When we push more commits, is there a way for us to know the results of the tests without asking you?

avdata99 commented 1 year ago

Any reason why the checks don't show up on the PR? When we push more commits, is there a way for us to know the results of the tests without asking you?

@jbrown-xentity, this repository takes care of the minutes to execute the GitHub actions. This is why it requires the authorization of a repository administrator user to run. Forks of this repository do execute these actions (including tests) and each external user can check their own tests.

jbrown-xentity commented 1 year ago

@amercader can you take a look?

jbrown-xentity commented 1 year ago

@amercader ping?