ckan / ckanext-harvest

Remote harvesting extension for CKAN
130 stars 203 forks source link

Do not duplicate harvest_extras if exist in root schema #521

Closed pdelboca closed 1 year ago

pdelboca commented 1 year ago

This PR refactors and document the logic of our dataset_before_index method.

With the new changes, harvest metadata will not be added to extras if it exist in the root schema of the dataset. This will allow other extensions or implementations to add harvest metadata to the main package schema without getting duplicated errors when trying to update or patch the dataset.

pdelboca commented 1 year ago

@amercader As a continuation of this PR I want to add some documentation about pkg_dict, data_dict and validated_data_dict on CKAN Docs.

I still don't get quite well the uses and difference betwen them.

amercader commented 1 year ago

@pdelboca This looks good!

re the different dicts: