Compatibility with the new SQLAlchemy version tested against this PR.
I noticed a problem caused by the unicode_safe validator recently added to the extras-value. It's not related to the current PR, but to make all tests green you have to manually remove unicode_safe from here. I'll investigate and report this problem separately.
Changes are mostly straightforward if you wonder why target.source = target.job.source removed: this code is executed inside an event listener that does not allow modifying relationship properties(harvest_object.source). Instead, you can only modify real columns that reference the related object(harvest_object.harvest_source_id). On the next line, right after the one I removed, exactly this thing happens, so the removed line did nothing anyway.
Compatibility with the new SQLAlchemy version tested against this PR.
I noticed a problem caused by the
unicode_safevalidator recently added to the extras-value. It's not related to the current PR, but to make all tests green you have to manually removeunicode_safefrom here. I'll investigate and report this problem separately.Changes are mostly straightforward if you wonder why
target.source = target.job.sourceremoved: this code is executed inside an event listener that does not allow modifying relationship properties(harvest_object.source). Instead, you can only modify real columns that reference the related object(harvest_object.harvest_source_id). On the next line, right after the one I removed, exactly this thing happens, so the removed line did nothing anyway.