search

ckan / ckanext-pages

A simple builtin CMS for CKAN sites
GNU General Public License v3.0
51 stars 101 forks source link

i18n #32

Closed trickvi closed 7 years ago

trickvi commented 8 years ago

Make ckanext-pages translatable with the newly added ITranslation interface

trickvi commented 8 years ago

ITranslation wasn't introduced until 2.4 I think. Should we be backwards compatible (crossing fingers and hoping not but that's why the test is failing)?

metaodi commented 8 years ago

@trickvi in general I think it's good to have support for the ITranslation interface, but I think we should be compatible with CKAN 2.3 if possible.

Maybe you could use something like that:

if p.toolkit.check_ckan_version(min_version='2.4'):
    p.implements(p.ITranslation)
amercader commented 7 years ago

Implemented in #41