search

ckan / ckanext-pdfview

PDF viewer for CKAN
GNU Affero General Public License v3.0
26 stars 47 forks source link

Migration to Python 3 and CKAN 2.9 #40

Closed pdelboca closed 3 years ago

pdelboca commented 3 years ago

This PR migrates the extension to Python 3 and also makes it compatible with CKAN 2.7, 2.8, 2.9, and master.

It changes the approach and instead of using PDF.js it uses an <object> tag to use native web browser PDF rendering. This PR is based on the built-in extension that will be soon available in CKAN by default.

This approach is a little bit more cleaner that the previous one and has less code to mantain.

PDF View on CKAN 2.9/Python 3:

pdf view 2 9

PDF View running on CKAN 2.8/Python 2:

pdf_view 2 8

PDF View with external PDF resources:

image

amercader commented 3 years ago

Thanks @pdelboca and @smotornyuk , this is now merged, and tagged with 0.0.6