ckan / ckanext-qa

CKAN QA Extension
MIT License
26 stars 50 forks source link

old kombu dependency #43

Open H-Plus-Time opened 7 years ago

H-Plus-Time commented 7 years ago

Travis builds don't appear to have been working for a fair while, due to incompatibilities introduced by the removal of _uuid_generate_random (python 2.7.11, presumably the version Travis uses in its build env). This has been fixed since 3.1.30 in kombu; what components require kombu to be pinned at 2.1.3?

KrzysztofMadejski commented 7 years ago

You mean 3.0.30?

It would require to update celery to 4.0 at least: https://github.com/celery/celery/commit/4075ffef06a9c3138bc6eb7eae1f68bed40638a3 Will you try that and see if it works?

BTW: Kombu and celery is not used directly in qa, it's practically a dependency of ckanext-archiver, so you have to update it there as well. See my commits https://github.com/DanePubliczneGovPl/ckanext-qa/commit/21db04476083e01ac80fefc1338a844fabbfc3b8 and https://github.com/DanePubliczneGovPl/ckanext-qa/commit/da8d6a2e30210b8566318b5b4c60dcc24c0fcbd2.