Closed florianm closed 9 years ago
Yes this is good. The ResourceGroup is not used by anyone.
We should just need to consider backwards compatibility - ideally this fix will work with earlier versions too. Can you put in a test for the CKAN version number or existence of model.ResourceGroup?
Done, but needs testing on older CKAN versions. Testing for existence of ResourceGroup works fine on my end (CKAN 2.3 source install).
This is fine, although I'm concerned about the duplication. Does this work? https://github.com/ckan/ckanext-qa/pull/10
PS I've merged your changes to test_tasks.py
Cheers for the help on this
This change removes three lines from reports.py which reference the now deleted
ckan.models.ResourceGroup
. This gets ckanext-qa to work with CKAN 2.3a (source install of master branch on Ubuntu 14.10 LTS on Amazon EC2 t2.medium).Two tests fail - likely more to do with my test setup.
However, both
paster qa update
and the GUI links work.Before this pull request is merged, someone with a better understanding of the purpose of ResourceGroup should make sure that removing it from this extension doesn't violate assumptions or business logic I'm not aware of.