search

ckan / ckanext-scheming

Easy, shareable custom CKAN schemas
Other
83 stars 160 forks source link

Organization try to use scheming.css by href, this cause 404 #288

Open ccancellieri opened 3 years ago

ccancellieri commented 3 years ago

When we use scheming for customized organization formats and we go over an organization the template is loaded:

https://github.com/ckan/ckanext-scheming/blob/d441d2dee72a7382a73de4185b01fae4b2d37473/ckanext/scheming/templates/organization/edit_base.html#L5

I think that this line is causing the issue, is redundant and can be deleted (maybe also the whole template can go...

Moreover we are already correctly importing the scheming.css thanks to:

https://github.com/ckan/ckanext-scheming/blob/master/ckanext/scheming/2.8_templates/scheming/snippets/scheming_asset.html

and https://github.com/ckan/ckanext-scheming/blob/d441d2dee72a7382a73de4185b01fae4b2d37473/ckanext/scheming/templates/base.html#L5

What do you think?

Patrick1Rhode commented 3 years ago

Hi @wardi, @wood-chris,

Do you need help closing this issue?

Regards

wardi commented 3 years ago

@Patrick1Rhode sure, a PR would be welcome

mutantsan commented 2 years ago

I guess it's still an issue and maybe the PR should be merged.