search

ckan / ckanext-spatial

Geospatial extension for CKAN
http://docs.ckan.org/projects/ckanext-spatial
126 stars 193 forks source link

Fix broken tests #199

Closed rossjones closed 6 years ago

rossjones commented 6 years ago

Tests were relying on _rest action calls which have now been removed in master (and 2.8) and therefore tests were failing.

Makes the tests work, although there is probably some effort required in determining why metadata_modified is not being returned from package_show calls.

Also caches the pip output and only tests again latest version of CKAN. For some reason, apart from the first test the following tests were attempting to run with postgres 10.1

rossjones commented 6 years ago

Mostly seems to fix the problem, but now downloading and building the patched libxml occassionally fails. Maybe we can vendor that file that is downloaded? Am asking because it's 5Mb but if you think it might be safer for the tests?

amercader commented 6 years ago

@rossjones I'd try to avoid adding the libxml2 file to the repo. IIRC this was only needed because the version of libxml2 shipped with precise (what Travis is using) was too old: http://docs.ckan.org/projects/ckanext-spatial/en/latest/install.html#when-running-the-spatial-harvesters

Maybe that's not needed any more or we can update the image used by Travis.

Or if the failures are persistent we can just host the file on S3, to make it more reliable

rossjones commented 6 years ago

🎉

rossjones commented 6 years ago

Seems to be happy now testing 2.5 -> 2.8 + master

amercader commented 6 years ago

Thanks @rossjones!