ckan / ckanext-spatial

Geospatial extension for CKAN
http://docs.ckan.org/projects/ckanext-spatial
126 stars 193 forks source link

[harvest] gmx:MimeFileType not supported #225

Closed jeanpommier closed 5 years ago

jeanpommier commented 5 years ago

Harvesting a geonetwork node, I encounter cases when instead of <gmd:name><gco:CharacterString>Fichier KMZ à télécharger</gco:CharacterString></gmd:name> I have <gmd:name><gmx:MimeFileType type="application/octet-stream">Fichier KMZ à télécharger</gmx:MimeFileType></gmd:name>. According to the ISO 10139 standard, this is allowed (see gmx extendedElements). But during harvesting, the tag gmx:MimeFileType is not retrieved and I get 'Unnamed resource'.

jeanpommier commented 5 years ago

I found it could be fixed by adding
"gmd:name/gmx:MimeFileType/text()", in https://github.com/ckan/ckanext-spatial/blob/master/ckanext/spatial/model/harvested_metadata.py#L182 and everywhere gco:CharacterString occurs Shall I submit a PR about this ?

jeanpommier commented 5 years ago

I've investigated on the geonetwork side to see how this MimeFileType thing could happen. It happens in some kinds of resources that geonetwork itself introduces the tag. So to support harvesting geonetwork using CSW, it should definitely be supported at least in the gmd:Name tag