ckan / ckanext-spatial

Geospatial extension for CKAN
http://docs.ckan.org/projects/ckanext-spatial
125 stars 192 forks source link

Supports Python3 #249

Closed smellman closed 3 years ago

smellman commented 3 years ago

~This PR doesn't support Python2 for CI and I test with only python3 environment.~

Zharktas commented 3 years ago

However, we can't remove python2 support from core extensions as long as python2 versions of ckan is still under support eg. ckan 2.8.

smellman commented 3 years ago

@Zharktas OK, I will try to support ckan 2.8, 2.9-python2, 2.9 and master.

smellman commented 3 years ago
howff commented 3 years ago

I have just tested the branch https://github.com/smellman/ckanext-spatial/tree/dev-py3 in ckan-2.9 python3 ubuntu20.04 and it worked for me (unlike the current ckan/ckanext-spatial which did not)

bonnland commented 3 years ago

Any idea when this could get merged? My organization is trying to move to CKAN 2.9 and python 3, and we rely heavily on this extension (harvesting ISO 19139).

Thanks for any info!

tomeksabala commented 3 years ago

I have also run some preliminary tests with this WIP branch on my CKAN 2.9 setup and it seemed to work. I am also really interested on what's the timeline for getting this merged in!

Thanks for a great work @smellman

tino097 commented 3 years ago

+1 to be merged @ckan/core

amercader commented 3 years ago

I'll do a final review this week, thanks @smellman and @smotornyuk for your work on this!

amercader commented 3 years ago

I've merged this branch plus a bunch of improvements and fixes to make it more future-proof (you can check commits 17c7ffd37fdfef4e354c3596b5a2b47d6abe3808 to 90ee774c86ea148eeb04905f9e8761c365df3fa8) and tagged it v1.0.0

Huge thanks to @smellman for finishing the great work that @smotornyuk started and taking this over the line.