ckan / ckanext-spatial

Geospatial extension for CKAN
http://docs.ckan.org/projects/ckanext-spatial
125 stars 191 forks source link

Lineage is missing on 19139 ISO base implementation #263

Closed ccancellieri closed 2 years ago

ccancellieri commented 2 years ago

Hi, I'm checking the havested model and I see that we are extracting correctly lineage but then it's not extracted.

This should be easy to be added.

I'm going to propose a pr on this.

ccancellieri commented 2 years ago

please keep this on hold, I would like to propose an improved version of the module, including what's fetched on the iso_model but not dumped into the package. Here is a draft

I'm creating 2 other integrations to provide Here is the matching schema: https://github.com/ccancellieri/ckanext-scheming_iso19115/blob/master/ckanext/scheming_iso19115/scheming/iso.yaml Here is the spatial_plugin integration overriding (and delegating, see TODO(s)): https://github.com/ccancellieri/ckanext-spatial/blob/a44750f78dd45a4b0e4d5cbed5f1a87d0bf20f99/ckanext/spatial/harvesters/iso19115/spatial_harvester.py#L1030-L1062 Here I'm extracting the extra fields putting them as dataset fields matching an existing iso19115 dataset format (provided by the iso scheming plugin

The result is an enriched 19139/19115 dataset format (called iso19115) validated and editable via scheming plugin interface.

I already have something in place ;)

Thanks

ccancellieri commented 2 years ago

The challenge now is backport to the core common improvements and face with presets to better present: