ckan / ckanext-spatial

Geospatial extension for CKAN
http://docs.ckan.org/projects/ckanext-spatial
126 stars 193 forks source link

Upgrade tests to check all envs, including CKAN 2.10 with Python 3.10 #308

Closed avdata99 closed 1 year ago

avdata99 commented 1 year ago

Related to #301

pyproj==2.6.1 is not workign for Python >= 3.9

This PR starts defining proper test for each possible environment The requirements.txt file update packages for python >= 3.9:

Incredibly, it look like all test are green for all those new packages Geometries commands for the RIDL application are working fine.

Alpine has a fixed Python version. It can not be easily changed. You can't use Python 3.8 or 3.9 with Alpine 3.16. We use Alpine 3.16 for CKAN 2.10 image If we want to test this extension with CKAN 2.10 and Python 3.8 we will need a new approach. Should we start building CKAN 2.10 (alpine 3.16) images with Python 3.8 and Python 3.9?

Also

amercader commented 1 year ago

@avdata99 I think that if Python 3.8 is tested with the CKAN 2.9 image then it's probably safe to assume that it will work on Python 3.9 + CKAN 2.10 (if the CKAN 2.10 tests pass)

avdata99 commented 1 year ago

@amercader I agree, this should work. I'll use the extension on RIDL and validate this. I removed the custom test for CKAN 2.10 with python 3.8 and python 3.9

avdata99 commented 1 year ago

Also @amercader, I added cache for this test runs https://github.com/avdata99/ckanext-spatial/commit/4caf2c3ebfba1d8d8a4693a8abec42cb50fcf673 If they are merged, next test runs will be faster

kikislater commented 1 year ago

pip-requirements needs to be modified as well

avdata99 commented 1 year ago

pip-requirements needs to be modified as well

@kikislater pip-requirements is just a link to the requirements file.

kikislater commented 1 year ago

ok sorry