ckan / ckanext-spatial

Geospatial extension for CKAN
http://docs.ckan.org/projects/ckanext-spatial
126 stars 193 forks source link

Shapely issue with numpy #334

Closed tino097 closed 2 weeks ago

tino097 commented 4 months ago

Fixing the issue with numpy https://github.com/shapely/shapely/issues/1972

tino097 commented 3 months ago

Hey @amercader can you please check this one

amercader commented 3 months ago

sorry @tino097 this slipped my mind, will check it tomorrow for sure

amercader commented 3 months ago

According to the issue linked, Shapely==2.0.4 should support Numpy>2:

https://github.com/shapely/shapely/issues/1972#issuecomment-2065312736

I tested the install in a fresh venv and both libraries were installed fine:

Installing collected packages: pytz, argparse, urllib3, six, pyyaml, pyparsing, numpy, lxml, idna, geojson, charset-normalizer, certifi, Shapely, requests, python-dateutil, pyproj, ckantoolkit, OWSLib
Successfully installed OWSLib-0.31.0 Shapely-2.0.4 argparse-1.4.0 certifi-2024.7.4 charset-normalizer-3.3.2 ckantoolkit-0.0.7 geojson-3.1.0 idna-3.7 lxml-5.3.0 numpy-2.0.1 pyparsing-3.1.2 pyproj-3.6.1 python-dateutil-2.9.0.post0 pytz-2024.1 pyyaml-6.0.2 requests-2.32.3 six-1.16.0 urllib3-2.2.2

Can you share the actual issue you are facing? Perhaps it can be solved in another way

amercader commented 2 weeks ago

Numpy>2 should be supported with the changes in https://github.com/ckan/ckanext-spatial/pull/341