Closed amercader closed 2 years ago
https://github.com/frictionlessdata/ckanext-validation/pull/56 fixes some of the errors but there are other problems that I'm unsure how to resolve, such as 'enqueue_job' not being called.
Our fork and Keitaro's (qld-gov-au and keitaroinc) now have Py3 compatibility, if you want to use them as a reference. Keitaro is using the ckan-dev Docker containers, which preload more and result in a faster build, while qld-gov-au has scenario tests using Behave, but they'll otherwise be quite similar if/when https://github.com/keitaroinc/ckanext-validation/pull/11 is merged.
:exclamation: No coverage uploaded for pull request base (
master@23dd8a5
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #55 +/- ##
=========================================
Coverage ? 82.64%
=========================================
Files ? 26
Lines ? 2149
Branches ? 0
=========================================
Hits ? 1776
Misses ? 373
Partials ? 0
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
Putting this out there in case someone wants to pick it up. I sadly run out of time before completion but I'd say that the py3/CKAN 2.9 support is 80% there, with still some things to iron out.