GS308EPP (double P) support?

[vanrace]

I just received my GS308EPP. I think the only difference with the supported GS308EP model is the extra power budget, but I could be wrong. It is not in the supported models list, maybe just because there was no one to test?

---

EDIT:

I tried to use it anyway of course, when trying to set up the integration I received an 'Unknown errror occurred'.

Then, not bothered by any Python- but with some outdated programming knowledge I added a new configuration based on the EP version to the models.py file and added it to the models array and lo and behold, it works!

Let me post the file contents below. Not a GIT user, sorry.... Maybe you could integrate the change if the review turns out okay? THANKS!!

BTW: Happy to do more testing if needed. I am on fw version V1.0.1.4

[vanrace]

Added/changed:

class GS308EPP(GS3xxSeries):
    MODEL_NAME = "GS308EPP"
    PORTS = 8
    POE_PORTS = [1, 2, 3, 4, 5, 6, 7, 8]
    POE_MAX_POWER_ALL_PORTS = 123
    CHECKS_AND_RESULTS = [
        ("check_login_form_rand", [True]),
        ("check_login_title_tag", ["GS308EPP"]),
    ]

MODELS = [
    GS105E,
    GS105Ev2,
    GS108E,
    GS108Ev3,
    GS305EP,
    GS308EP,
    GS308EPP,
    GS316EP,
    GS316EPP,
]

[loso2255]

+1

[foxey]

@vanrace It's probably just a matter of adding the identification to the models.py file, but do me a favor and share the debug output for the integration with me.

[vanrace]

@foxey , thanks for answering. , please read the rest of the post, I added it myself to the models.py and it works now, i shared the changes I did, just not sure how to add it to the repository. Hope you can help there! Thanks for all your work!!

[foxey]

@vanrace I missed that. Thanks for pointing it out. Ideally, you'd create a pull request, but since these changes are so minor, let me add them to the next release (unless you want to learn git 🙂)

[vanrace]

Maybe I will give it a try, I’ll keep you updated.

[foxey]

Hi @vanrace, I published a new release (v0.6.5) with GS308EPP support. Can you apply the update and let me know if it works? Please note that the code has undergone significant refactoring and the release introduces a minor breaking change. A fix for this is included in the release notes.

[loso2255]

i can confirm, at least for me, that is working fine for me

[vanrace]

@loso2255 : nice! Here it works as well although I did not test the power control since I only have some stuff on it I don’t like to power cycle at the moment (like my HomeAssistant rpi )

thanks for the quick action! i appreciate it

[foxey]

Good to hear! BTW you can also power cycle an empty port (if you still have one), but apart from the logging, you won't have evidence that it really works. I'll close this issue for now. Please reopen it if you discover something is not working as expected.

[vanrace]

Tested power cycle in the meantime: works!