search

ckaznable / tenki

tty-clock with weather effect
MIT License
99 stars 5 forks source link

I added color customization #1

Closed Sellsword9 closed 8 months ago

Sellsword9 commented 8 months ago

Honestly I just saw this repository somewhere, took a look at it, and decided to give it a try. Then I ended up doing one small nitpick (cargo clean instead of rm -rf target, i don't like having a file containing any kind of rm -rf anywhere on my pc/the user's ones). Then I went deeper on the code and run it. I addded an arg option for the color, which displays correctly.

Disclaimer:

Sometimes the buffer overflows: Tried --mode snow --color black and it didn't work, something tried accessing a non-existant position in the buffer. If this is fine to you or you can&want to fix it, accept the PR. If you want all commits to be "100% release-ready", then be aware of this possible bug. I have not been able to reproduce it since that, so I do not know how or why that happened. Maybe it had nothing to do with colors, in which case this should be an issue.

ckaznable commented 8 months ago

Thanks for PR, can you add a description of the options in the Usage section of the README?

There's also the overflow problem, which shouldn't be happening, and I may try to fix that in the future.

Sellsword9 commented 8 months ago

That should be it

ckaznable commented 8 months ago

LGTM, Thanks.