search

ckaznable / tenki

tty-clock with weather effect
MIT License
99 stars 5 forks source link

--tps and --fps mixed up? #22

Open charklie opened 5 months ago

charklie commented 5 months ago

When ever i use --fps and set it to 140 and use --show-fps the indicator stays at 60, while if i use --tps and set it to 150 and use --show-fps the indicator shows 150.

Mabye also consider making -f and -t shorthand for --fps and --tps

charklie commented 5 months ago

Oh yeah, star mode doesnt work either.

[charlie@charend ~]$ tenki --mode star
thread 'main' panicked at src/weather/mod.rs:19:18:
has not been implemented yet for this mode
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)
ckaznable commented 5 months ago

The calculation of --show-fps is not quite accurate. This was originally a flag I used for debugging.

And I haven't implemented star mode yet, so I don't have much time to do it lately 🥲

ckaznable commented 5 months ago

-t and -f has been released on v1.10.0

MrDwarf7 commented 1 month ago

Would it be possible to apply similar logic sort of how video games do their calculations to de-couple tick rate & fps? Getting some weird effects happening.

I'll try and have a look over the code and see if I can fix it myself, but figure I'll raise it here as a +1

ckaznable commented 1 month ago

If there's an example, I can understand what the problem is, because the way doing it now is my own interpretation, and I'm not sure it's the right one.

Anyway, more PR are welcome.