ckb-cell / rgbpp-sdk

Utilities for Bitcoin and RGB++ asset integration
ISC License
52 stars 14 forks source link

Add GitHub action workflows to test the RGB++ examples #47

Open Flouse opened 3 months ago

Flouse commented 3 months ago

RGB++ examples

https://github.com/ckb-cell/rgbpp-sdk/tree/main/examples/rgbpp

TODOs

Dawn-githup commented 2 months ago
Dawn-githup commented 2 months ago

TODOs

  • [x] read private key from .env

I don't seem to have permission to set secrets

Demo version: https://github.com/Dawn-githup/rgbpp-sdk/actions/runs/8975548148/job/24650388018

Dawn-githup commented 1 month ago
  • [ ] discussion: When is a good time to deprecate `examples/rgbpp/xudt/1~3 ? @Dawn-githup @duanyytop @ShookLyngs motivation: to reduce duplication of tests

I believe it is not a good time to abandon "examples/rgbpp/xudt/1~3" at the moment. Currently, updates are quite frequent, and to improve testing efficiency, tests/xudt are using L2 distribution.

"examples/rgbpp/xudt/" contains some launch parts. If we enable it now, developers will need to check examples in both the "examples" and "tests" directories.

Once the rgb-sdk updates are less frequent, it will no longer be necessary to maintain two sets of code, and we can consider enabling "examples".

Dawn-githup commented 3 weeks ago

@Flouse @ShookLyngs @duanyytop

Flouse commented 3 weeks ago
  • intend to modify the workflow to trigger manually to avoid wasting resources.

sounds reasonable