search

ckb-js / kuai

A protocol and framework for building universal dapps on Nervos CKB
MIT License
22 stars 11 forks source link

Optimize routes in declarative way #159

Closed Keith-CY closed 1 year ago

Keith-CY commented 1 year ago

Now the route in the mvp dapp is declared in an imperative way(https://github.com/ckb-js/kuai/blob/91a5ad378b47a420970fde6e86e0b7f2ddf72bda/packages/samples/mvp-dapp/src/app.controller.ts#L89-L92), which is not easy to read and maintain

It could be adjusted in a declarative way, as nest.js did(https://docs.nestjs.com/controllers#routing). This optimization could be implemented in IO layers

Keith-CY commented 1 year ago

how is it going

Keith-CY commented 1 year ago

PR: https://github.com/ckb-js/kuai/pull/191