nus-pe-bot
commented
2 years ago Team's Response
As mentioned in the documentation, after corrupting the data file, you would have to re-launch the app, execute a command, and then close the app for the backup file to appear. Hence, this reported bug was not reproducible and is thus rejected.
An image of the documentation is shown below:
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: I followed the exact set of instructions given in the manual testing section of your Developer Guide, but I do not see any backup files. I am unable to add videos greater than 5MiB here so I will add screenshots for each step taken. The bug clearly exists and cannot be rejected.
Taken from part 7.8 of the Developer Guide:
Prerequisites: There must be an “addressbook.json” data file in the “[Abπ location]/data/” folder:
Remove a line from “addressbook.json” to corrupt it.
Launch “Abpi.jar”.
Execute add n/bob p/123 e/123@example.com a/123 street.
Close the app.
Expected:
When the corrupted data file is read, an empty addressbook will be loaded. After the command add n/bob p/123 e/123@example.com a/123 street is executed, the current list overwrites the existing data file. When the app is closed, a backup copy of the previous data file will be created, named as “backup_[DD-MM-YY HH-MM-SS].json” in the same folder.
Actual:
No backup files as seen below
Tried again just in case backup was not saved because the previous data and the new data only consisted of Bob:
Skipped repetitive screenshots for this part.
Prerequisites: There must be an “addressbook.json” data file in the “[Abπ location]/data/” folder
Remove a line from “addressbook.json” to corrupt it.
Launch “Abpi.jar”.
Execute add n/alice p/123 e/123@example.com a/123 street.
Close the app.
Expected:
When the corrupted data file is read, an empty addressbook will be loaded. After the command add n/alice p/123 e/123@example.com a/123 street is executed, the current list overwrites the existing data file. When the app is closed, a backup copy of the previous data file will be created, named as “backup_[DD-MM-YY HH-MM-SS].json” in the same folder.
Actual:
No backup files again as seen below
Steps to reproduce:
Remove the tags key and value pair in json file. (dont remove last comma)
Expected:
Backup file
Actual:
No backup
Screenshot(s):