Open ckcherry23 opened 2 years ago
The link provided in the acknowledgement is correct. I am acknowledging that I have referred to the undo and redo proposed implementation from the Ab3 DeveloperGuide from https://se-education.org/addressbook-level3/DeveloperGuide.html#proposed-undoredo-feature
Team chose [response.Rejected
]
Reason for disagreement: This indicates that the Acknowledgements section in your Developer Guide is incomplete.
It is necessary to indicate all sources from which you reused or adapted your ideas, code, and documentation. This means that you have to acknowledge the AB3 documentation, the AB3 GitHub repo for the source code, the libraries used (JavaFX, JUnit5, Jackson, etc.), and any other sources that you reused ideas from.
The point which states that AB3 code does not need to be acknowledged is for within the code and not in the documentation. Minimally, it is necessary to state that your project was adapted from the AB3 source code in the Developer Guide and you must give a link to their GitHub repo as an acknowledgement to their work. This is the acknowledgement I expected to see in your Developer Guide but instead I saw a link to the undo-redo feature.
Moreover, the link you have provided for the undo-redo feature is not a working hyperlink.
I completely disagree with the rejected response.
https://se-education.org/addressbook-level3/DeveloperGuide.html#proposed-undoredo-feature
The undo redo feature has been linked as acknowledgement