search

ckczzj / PDAE

Official PyTorch implementation of PDAE (NeurIPS 2022)
271 stars 20 forks source link

Confusion about loss #5

Closed pearl-rabbit closed 1 year ago

pearl-rabbit commented 1 year ago

Hello, the symbol in front of gradient estimator G in formula (7) and Appendix A of the paper is '+', but the text description after formula (7) and code use '-'. I am a bit confused about this, and I hope you can help me answer it.

ckczzj commented 1 year ago

In paper, the loss of certain timestep is: CodeCogsEqn (1), and you can write it as: CodeCogsEqn, where CodeCogsEqn (1) is just the shift_coef defined here: https://github.com/ckczzj/PDAE/blob/fbba0355634861196aed8b80b9ba4948ed210ab9/model/diffusion/gaussian_diffusion.py#L56

pearl-rabbit commented 1 year ago

Thanks for your helpful reply, now I understand.