search

ckdake / setler

Setler lets you use the 'Feature Flags' pattern or add settings to models in Rails
MIT License
84 stars 21 forks source link

Fixing defaults #18

Closed rheaton closed 10 years ago

rheaton commented 12 years ago

Here are my updates with latest commit the modification for precedences of default and scoped settings.

Discussion: https://github.com/ckdake/setler/issues/16

ckdake commented 12 years ago

@stevenharman could you take a look at this and see if this works with your setup?

rheaton commented 12 years ago

any update on this?

ckdake commented 12 years ago

Still waiting on @stevenharman as the last attempt at a fix at this broke some things in a big way for a project he is working on. I'll bug him in person the next time I see him and we'll see if this works and if we can merge it.

rheaton commented 12 years ago

Thanks!

stevenharman commented 12 years ago

I've been on the lake - Internet-free - for the past week, but will try to take a look this week.

ckdake commented 10 years ago

This looks to be superseded by #28, ok to close this one?

stevenharman commented 10 years ago

I'm pretty out of touch with this, so feel free to close and we can always reopen if needed.

rheaton commented 10 years ago

Yes, this one can go! :+1: