ckdevrel / vcardio

Automatically exported from code.google.com/p/vcardio
0 stars 0 forks source link

Support SMS VCard receiving #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Was thinking about an app for this functionality but after all it might be 
better to just integrate it into yours...

I attached a draft of the code needed to receive an sms and add it to the 
contact list. (correct the package name to the one of your project)

add this to your manifest:
<receiver android:name=".SMSReceiver" android:enabled="true">
  <intent-filter>
   <action android:name="android.provider.Telephony.SMS_RECEIVED" />
  </intent-filter>
</receiver>

and 

<uses-permission android:name="android.permission.RECEIVE_SMS" />

Please add me as contributor if you integrate the provided code.

Original issue reported on code.google.com by franci...@gmail.com on 28 Jun 2009 at 8:48

Attachments:

GoogleCodeExporter commented 9 years ago
I'll have a look at this shortly, but it sounds like a good idea.

Original comment by duckt...@gmail.com on 30 Jun 2009 at 3:53

GoogleCodeExporter commented 9 years ago
I've added your code to the project. Unfortunately, it doesn't entirely work. I
created a new branch "sms" for development of this feature. I've added you as a
member to this project, so you should now have commit access (using Mercurial).
Please commit any changes to the "sms" branch rather than the default one.

I think the following are needed before merging into the main branch: 
1. It should actually work.
2. There should be a preference (defaulting to "off") for whether SMS messages 
are
automatically received by the program. Otherwise, this may cause a security 
problem
(since users don't have control over what SMS messages they receive).
3. Ideally, it should display the vCard to the user and ask whether to add it to
contacts (rather than automatically doing so).

Original comment by duckt...@gmail.com on 1 Jul 2009 at 4:49

GoogleCodeExporter commented 9 years ago
strange that it does not work, I'll have a look at it

Original comment by franci...@gmail.com on 1 Jul 2009 at 9:43

GoogleCodeExporter commented 9 years ago
the contact is added but there is no proper way of getting rid of the 
notification

Original comment by franci...@gmail.com on 1 Jul 2009 at 9:55

GoogleCodeExporter commented 9 years ago
did some initial work on an activity to accept the vcard, more later this week

Original comment by franci...@gmail.com on 1 Jul 2009 at 11:24

GoogleCodeExporter commented 9 years ago
ducktayp, can you have a look at it now and see if 1 and 3 are fixed
I need to read up on how to save user preferences so I can skip notification 
when that 
functionality is disabled

Original comment by franci...@gmail.com on 2 Jul 2009 at 9:15

GoogleCodeExporter commented 9 years ago
Just added a checkbox to the main app activity to enable or disable sms vcard 
receiving. So that's it for 2. Maybe we should put that option in a real 
android 
settings menu.
All we might need is a fancier vcard view. But for that the VCardIO class needs 
to be 
changed.

Original comment by franci...@gmail.com on 2 Jul 2009 at 9:41

GoogleCodeExporter commented 9 years ago
francisdb, I can't see any changes in the repository. Did you do an "hg push" 
after
committing?

Original comment by duckt...@gmail.com on 3 Jul 2009 at 3:51

GoogleCodeExporter commented 9 years ago
first time I use mercurial, push performed

Original comment by franci...@gmail.com on 3 Jul 2009 at 5:48

GoogleCodeExporter commented 9 years ago
now showing the contact after import of the vcard
ducktayp, can you have a look at it?

Original comment by franci...@gmail.com on 10 Jul 2009 at 10:46

GoogleCodeExporter commented 9 years ago
Ducktayp, did you check out my changes? I'd like to see them released :-)

Original comment by franci...@gmail.com on 24 Jul 2009 at 2:38

GoogleCodeExporter commented 9 years ago
It looks good to me. I didn't have time to do much testing, though.

I put up a version in the downloads section and a pointer from the project 
homepage.
If there are no significant bugs filed in the next few weeks, I'll make it the
featured version and upload to the market.

Original comment by duckt...@gmail.com on 27 Jul 2009 at 5:41

GoogleCodeExporter commented 9 years ago
that's great news :-)

Original comment by franci...@gmail.com on 1 Aug 2009 at 9:58

GoogleCodeExporter commented 9 years ago

Original comment by duckt...@gmail.com on 12 Oct 2009 at 6:50