search

ckdo / airplay2-receiver

AirPlay 2 receiver - python implementation only for testing
125 stars 7 forks source link

Use an actual interface IP #16

Closed systemcrash closed 3 years ago

systemcrash commented 3 years ago

instead of "0.0.0.0" which seems to cause later connection problems, esp from localhost 127.0.0.1 IP. Also accelerates connection attempts, somewhat.

For people with only IPv6 - they might need to run at least Python 3.8, because httpd and TCPSocket (in earlier versions of python3) don't like an address with a ":" in it....

systemcrash commented 3 years ago

Tested on macOS 10.15.7.

PaulWieland commented 3 years ago

Does this address Issue https://github.com/ckdo/airplay2-receiver/issues/12 ?

systemcrash commented 3 years ago

Does this address Issue #12 ?

Not intentionally. It's possible that line 735 is the cause of that crash - I suspect it would be some kind of array index out of bounds:

    IPV6 = ifen[ni.AF_INET6][0]["addr"].split("%")[0]
systemcrash commented 3 years ago

Pushed some fixes which should take care of that.

systemcrash commented 3 years ago

Sure. But upstream is not currently in a usable state for me to verify that this patch works in that code... Can always blindly push tho. 😅