Release Build Includes Test Directory

[bmulholland]

I'm building a CKEditor build from source. I have tried release/4.3.x and release/4.4.x branches of that directory, which use version 1.7.2 and version 2.0.1, respectively. I have also manually tried CKBuilder 2.0.2 with the same command used for version 2.0.1. Versions 2.0.1 and 2.0.2 include an extra tests directory that should not be present. Also included are extra files that may or may not be expected; I'm not familiar.

I'm using build.sh: release/4.3.x uses the command java -jar ckbuilder/$CKBUILDER_VERSION/ckbuilder.jar --build ../../ release --version="4.3.5 DEV" --build-config build-config.js --overwrite "$@" release/4.4.x uses the command java -jar ckbuilder/$CKBUILDER_VERSION/ckbuilder.jar --build ../../ release --version="4.4.2 DEV" --overwrite $JAVA_ARGS

Results: CKBuilder 2.0.1 and 2.0.2 includes extra directories and files I would not expect in a release build. CHANGES.md LICENSE.md adapters bender.js ckeditor.js config.js contents.css lang package.json plugins samples skins styles.js tests CKBuilder 1.7.2 produces: CHANGES.md LICENSE.md adapters ckeditor.js config.js contents.css lang plugins samples skins styles.js

Expected: No directories needed for testing etc, as with 1.7.2. I'm not sure if bender.js, package.json, etc are needed by the new release; they may.

Easy steps to repro:

• Clone the ckeditor-dev repo.
• Check out release/4.3.x
• Run cd dev/builder/ && build.sh && ls release/ckeditor.
• Check out release/4.4.x and run the same command.

[adelura]

Files to be copied during build process are determined in build-config.js. As far as I can see files which you mentioned are included in config. Could you please check what you got in your build-config.js file which you use for build process, and assure that files/directories which you mentioned are included in that config? I think problem is with outdated config.

[Reinmar]

I can see that in these official configs:

• https://github.com/ckeditor/ckeditor-dev/blob/master/dev/builder/build-config.js
• https://github.com/ckeditor/ckeditor-presets/blob/master/presets/full-build-config.js

the tests, package.json and bender* files are ignored, so our configs are up to date. This issue can be closed.

[bmulholland]

Thanks - I confirmed that my build-config does not include these directories/files as "ignore". The build-config.js I'm using is based on the build-config generated by the online ckbuilder less than a year ago. I guess I'll have to keep checking the build-config presets every release to confirm that there aren't any changes.

[adelura]

We will add information about config in readme. Let me do this with this issue.