search

ckeditor / ckeditor-boilerplate

A boilerplate for modern git based projects
Other
6 stars 4 forks source link

Grunt task to run both JSCS and JSHint at the same time #6

Open Reinmar opened 9 years ago

Reinmar commented 9 years ago

Currently you need to execute:

grunt jshint:all && grunt jscs:all

And after closing #5:

grunt jshint foo/bar.js && grunt jscs foo/bar.js

There could be a generic lint task so the developer will not even need to know that we're using JSCS and JSHint. The new task should be able to run in all 3 ways - all, git, path.

Reinmar commented 9 years ago

Pushed branch https://github.com/ckeditor/ckeditor-boilerplate/tree/t/6

It removes all these hacks that we had, because they made it impossible or just incomprehensible how we can implement the lint task.

I find the new approach much cleaner and understandable. We take the contrib task, change its name, and run it with dynamically defined config.

I still want to improve one thing - make grunt lint running only grunt lint:git (now it runs both targets).

Reinmar commented 9 years ago

I still want to improve one thing - make grunt lint running only grunt lint:git (now it runs both targets).

Done.