search

ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

Critical bug when ckeditor removed from dom before loaded #110

Closed bhugot closed 4 years ago

bhugot commented 4 years ago

Are you reporting a feature request or a bug?

Hello, we found a bug maybe related to ckeditor itself. if the component is removed from dom before initialisation you get Cannot read property 'unselectable' of null.

here is a sample https://stackblitz.com/edit/angular-ivy-rgaeks?file=src%2Fapp%2Fdemo%2Fdemo.component.ts

If you either have a way to fix this or could fix it. Regards

bhugot commented 4 years ago

The fix is here #111

f1ames commented 4 years ago

Fixed in d3ceee6.

bhugot commented 4 years ago

Any ETA on release? Thanks

f1ames commented 4 years ago

We plan to release new version next week.

f1ames commented 4 years ago

Hi @bhugot, the new package version (1.2.2) with the fix is out on NPM (https://www.npmjs.com/package/ckeditor4-angular) :tada::clap:

boris27 commented 4 years ago

hi guys, i have little different situation, and your fix in 1.2.2 doesnt work for me

this is example of above code, little modified to exampled my situation) https://stackblitz.com/edit/angular-ivy-taveju?file=src%2Fapp%2Fapp.component.ts

can you help with this? @f1ames

f1ames commented 4 years ago

Hi @boris27,

please report a separate issue in this repository describing your case so we can keep track of your issue.