ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

Unstable 'paste' and 'afterPaste' tests on FF #119

Open Dumluregn opened 4 years ago

Dumluregn commented 4 years ago

Are you reporting a feature request or a bug?

Unstable tests

Provide detailed reproduction steps (if any)

  1. Run tests with npm run test
  2. See the result in FF
  3. If everything passed, try again

Expected result

Tests pass each time.

Actual result

Tests for paste and afterPaste events are unstable and fail sometimes.

Other details

I'm not sure but it can be caused by changes introduced in #115.

f1ames commented 4 years ago

That's sad as we just fixed it for IE11 :sob: Anyway, maybe fixes introduced in #115 should be done for IE11 only and for the rest of the browsers it should be done as before the fix :thinking:

jacekbogdanski commented 4 years ago

I cannot reproduce it on Linux Fedora 32. They also don't seem to fail on CI. @Dumluregn is this issue macOS specific?

Dumluregn commented 4 years ago

Not sure. It occurs pretty consistently for me, so if you can't reproduce it you may be right that it happens on macOS only. @f1ames @hub33k could you check if tests fail on your machines?

hub33k commented 4 years ago

It fails on my machine (Manjaro Linux). For the first time it passes but when I run tests for the second time, it fails.

Dumluregn commented 4 years ago

It seems the tests pass on FF if the browser is focused and fail otherwise. Could you guys check if that's true for you? @jacekbogdanski @hub33k

hub33k commented 4 years ago

Yes, these tests fails for me when FF is not focused.

f1ames commented 4 years ago

Let's leave it for now since it passes on CI.

jacekbogdanski commented 3 years ago

I see that these tests are failing for me know just regularly: image

(4 of them based on afterPaste event)

Edit: I didn't notice https://github.com/ckeditor/ckeditor4-angular/issues/119#issuecomment-666331780 and indeed that's the troubling part.

Comandeer commented 1 year ago

Seems like these tests always fail now :disappointed: