ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

Improve stability of asynchronous unit tests #129

Closed jacekbogdanski closed 4 years ago

jacekbogdanski commented 4 years ago

Some tests asynchronous tests have been written incorrectly and may fail unexpectedly because test runner is not able to wait for the results.

As an example: https://github.com/ckeditor/ckeditor4-angular/blob/4c94a774e8a85c054853d700dd6866eafd12070f/src/ckeditor/ckeditor.helpers.spec.ts#L54-L56

This test is calling two async functions but is not waiting once they finish which may break other tests from the same suite.