Update NPM dev-only dependencies

ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.

Other

55 stars 32 forks source link

Update NPM dev-only dependencies #147

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

Updated NPM dev-only dependencies.

f1ames commented 3 years ago

Tests breaks completely so it seems it's related to Angular 11. We should probably take a look at #148 soon.

Dumluregn commented 3 years ago

I can't post a reference as I've already restarted the build for production dependencies, but the log result was that Travis doesn't support Angular 11 yet, so it's possible that it still works. Still, I'll test it locally with Karma.

Dumluregn commented 3 years ago

Bumping just those deps is indeed causing errors, however if you also apply the changes proposed in https://github.com/ckeditor/ckeditor4-angular/pull/146, everything works fine. That indicates we shouldn't divide bumping those dependencies, so it would be good to perform https://github.com/ckeditor/ckeditor4-angular/issues/151 as soon as possible.

Dumluregn commented 3 years ago

Changes from this PR are also in #152.