search

ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

Expose API notifying about loaded CKEDITOR namespace #149

Closed Dumluregn closed 3 years ago

Dumluregn commented 3 years ago

Once the CKEDITOR namespace is loaded, we'll emit a namespaceLoaded event.

Testing this PR was a bit painful as there were issues with having multiple <ckeditor> components simultaneously (I reported https://github.com/ckeditor/ckeditor4/issues/4390 to fix that in the future).

Closes #143.

github-actions[bot] commented 3 years ago

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

github-actions[bot] commented 3 years ago

There was no activity regarding this pull request in the last 14 days. We're closing it for now. Still, feel free to provide us with requested feedback so that we can reopen it.

Dumluregn commented 3 years ago

We should ensure that ckeditor-integrations-common content is transpiled to ES 5 to avoid IE11 issue like in https://github.com/ckeditor/ckeditor4-vue/issues/75.

github-actions[bot] commented 3 years ago

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

github-actions[bot] commented 3 years ago

There was no activity regarding this pull request in the last 14 days. We're closing it for now. Still, feel free to provide us with requested feedback so that we can reopen it.

github-actions[bot] commented 3 years ago

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

Dumluregn commented 3 years ago

Rebased onto latest master.

f1ames commented 3 years ago

@Dumluregn should we mark it as blocked since it's waiting for ckeditor/ckeditor4-integrations-common#12? :thinking:

Dumluregn commented 3 years ago

I've tested it and TBH it seems to be working, probably because of the differences in the build workflow in Angular 🤔 So it isn't blocked.

BTW I've accidentally discovered that with one of the deps update (didn't figure it out which one yet) browsers stopped closing after running tests, which causes CI to fail every time since there is no response 😞 and single-run option in Karma seems to be irresponsive in this matter, so I'll try to bisect the deps to find out what caused it and fix it in this PR too.

Dumluregn commented 3 years ago

Blocked by https://github.com/ckeditor/ckeditor4-angular/issues/163.

github-actions[bot] commented 3 years ago

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

github-actions[bot] commented 3 years ago

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

github-actions[bot] commented 3 years ago

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

Dumluregn commented 3 years ago

Rebased onto latest master.

Dumluregn commented 3 years ago

Due to testing issue caused probably by https://github.com/ckeditor/ckeditor4/issues/4390 we came to a conclusion to extract adding unit tests for this PR to a separate issue (https://github.com/ckeditor/ckeditor4-angular/issues/172).

We have kind of a manual test here instead (similar as in Vue integration):

  1. Build an app (ng serve).
  2. Open it in browser.
  3. Check console.

Expected: There should be only one Namespace loaded by [classic/inline] editor. log.

CI is green and PR is ready for review.

github-actions[bot] commented 3 years ago

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

github-actions[bot] commented 3 years ago

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

Dumluregn commented 3 years ago

CI failed because of https://github.com/ckeditor/ckeditor4-angular/issues/72 and it seems that it caused an avalanche of the following errors.