search

ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

Are root package.json production dependencies needed #151

Closed f1ames closed 3 years ago

f1ames commented 3 years ago

Are you reporting a feature request or a bug?

Task

At the moment root package.json file have both dev dependencies:

https://github.com/ckeditor/ckeditor4-angular/blob/0c2193073445d5bbd5d76a06de05a4927ea15fc1/package.json#L45-L72

and productions ones:

https://github.com/ckeditor/ckeditor4-angular/blob/0c2193073445d5bbd5d76a06de05a4927ea15fc1/package.json#L29-L44

However, the integration works in a way that this package.json file is only used for development (private: true) and production one is located in https://github.com/ckeditor/ckeditor4-angular/blob/master/src/ckeditor/package.json having it's own set of production (and peer) dependencies:

https://github.com/ckeditor/ckeditor4-angular/blob/0c2193073445d5bbd5d76a06de05a4927ea15fc1/src/ckeditor/package.json#L43-L45

https://github.com/ckeditor/ckeditor4-angular/blob/0c2193073445d5bbd5d76a06de05a4927ea15fc1/src/ckeditor/package.json#L21-L25

And so I wonder if root package.json shouldn't only have dev dependencies? cc @Dumluregn @Comandeer

Dumluregn commented 3 years ago

I'm testing it right now, it seems all deps could be indeed devDependencies. As long as they are not included in the package anyway it shouldn't make any difference, but from my perspective it's worth to move those entries for clarity.

Comandeer commented 3 years ago

Yes, if the root package.json is used only for development purposes, it should have only dev dependencies.

CKEditorBot commented 3 years ago

Closed in https://github.com/ckeditor/ckeditor4-angular/pull/152