Closed sculpt0r closed 2 years ago
I suppose this should be done after the release of CKEditor with https://github.com/ckeditor/ckeditor4/pull/4463, so when 4.17.0
is out? And we should mark it as blocked for now (here and in the other integration repos)?
Actually, it can be done without https://github.com/ckeditor/ckeditor4/pull/4463. It will help prevent errors until reattach happen. So very partially, but still ;)
And indeed, only after 4.17.0
release.
So I mark all of them as blocked until the next major release.
Since https://github.com/ckeditor/ckeditor4/releases/tag/4.17.0 it is no longer blocked.
Are you reporting a feature request or a bug?
Feature
Base on our investigation on https://github.com/ckeditor/ckeditor4/issues/4390 issue and fix we provide for it: https://github.com/ckeditor/ckeditor4/pull/4463. We should use the
delayIfDetached
config set totrue
by default in integrations, just to prevent any issue. Also, we need to adjust editor creation: to properly mantain editor data (https://github.com/ckeditor/ckeditor4/issues/4390#issuecomment-849534046)https://github.com/ckeditor/ckeditor4-angular/blob/a6be961ec82422925c998c39832968ee1615cbae/src/ckeditor/ckeditor.component.ts#L302-L304
The above line assumes we get editor instance, but that doesn't have to be true with delayed creation.
Expected result
What is the expected result of the above steps?
Actual result
What is the actual result of the above steps?
Other details