ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

Revamp unit tests structure #210

Open Dumluregn opened 3 years ago

Dumluregn commented 3 years ago

Are you reporting a feature request or a bug?

Task

Details

See https://github.com/ckeditor/ckeditor4-angular/pull/202#pullrequestreview-697143919:

Besides I have a few thoughts regarding tests of ckeditor4-angular in general. There is no clear distinction between unit tests and E2E tests. The only true unit tests are here. Other test files such as demo-form.component.spec.ts and simple-usage.component.spec.ts test main component indirectly and resemble E2E scenarios. On top of that we have app.e2e-spec.ts. This is quite confusing to me.