search

ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
51 stars 32 forks source link

508 Accessibility - issue on ckeditor #241

Closed RahulPatil-REISys closed 1 year ago

RahulPatil-REISys commented 1 year ago

Type of report

Bug

Provide detailed reproduction steps (if any)

Integrated ckeditor. Found following issues by using various accessibility tools like Sortsite and Wave.

Sortsite tool

Warning -

  1. aria-disabled=true should not be used on links. If a link needs to be disabled, remove the href attribute.

Wave tool

Error - Missing form label Warning - Very small text

Please Guide for clearing such errors and warnings.

Comandeer commented 1 year ago

Could you provide more information about where these issues are present?

RahulPatil-REISys commented 1 year ago

Please refer to the screenshot attached.

Wave tool Error - Missing form label

missing-form-label

Wave Tool Warning - Very small text very-small-text

Sortsite Tool Warning - aria-disabled=true should not be used on links. If a link needs to be disabled, remove the href attribute. sortsite

Comandeer commented 1 year ago

Error - Missing form label

If I understand the screen correctly, this error points to the hidden textarea that is replaced by the editor's instance. In that case, properly labeling the element is a task of the integrator and it's not part of the editor.

Warning -
1. aria-disabled=true should not be used on links. If a link needs to be disabled, remove the href attribute.

Per ARIA specification:

While aria-disabled and proper scripting can successfully disable an element with role link, fully disabling a host language equivalent can be problematic. Authors are advised not to use aria-disabled on elements that cannot be disabled through features of the host language alone.

This warning is not applicable in the context of the editor as the intended behavior is only to disable the click action and keep the element focusable. The specification points to it as the acceptable behavior:

Disabled elements might not receive focus from the tab order.

Warning - Very small text

This seems to be an error on the WAVE side as it's present only when the styles for the page are switched off. According to the tool, it's for the text that has a 10px or lower font size – but the marked-up text has a 16px font size. The error is not present at all if styles aren't switched off.

As none of the reported issues are applicable to the editor, I'm closing the issue.