ckeditor / ckeditor4-angular

Official CKEditor 4 Angular component.
Other
55 stars 32 forks source link

Version 4.0.0 does not support Angular 16 #249

Closed henkkelder closed 1 year ago

henkkelder commented 1 year ago

It appears the just released version 4.0.0 does not support Angular 16 :-(

This likely means that the library (ckeditor4-angular) which declares CKEditorModule is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

Comandeer commented 1 year ago

@henkkelder, could you recheck? I've prepared a sample application with Angular 16 and it seems to work.

henkkelder commented 1 year ago

The link to your sample application doesn't seem to go anywhere. I see only this : {"originalErr":{}}

But I tried it a couple of days ago and this morning I tried it again. Result was the same.

Somehow the difference is in how the distribution is build. I had cloned your repository and made a build that worked ok. The distributable version I have build creates ckeditor.module.d.ts as:

import * as i0 from "@angular/core";
import * as i1 from "./ckeditor.component";
import * as i2 from "@angular/forms";
import * as i3 from "@angular/common";
export declare class CKEditorModule {
    static ɵfac: i0.ɵɵFactoryDeclaration<CKEditorModule, never>;
    static ɵmod: i0.ɵɵNgModuleDeclaration<CKEditorModule, [typeof i1.CKEditorComponent], [typeof i2.FormsModule, typeof i3.CommonModule], [typeof i1.CKEditorComponent]>;
    static ɵinj: i0.ɵɵInjectorDeclaration<CKEditorModule>;
}
export * from './ckeditor';
export { CKEditorComponent } from './ckeditor.component';

Your version is:

 * @license Copyright (c) 2003-2023, CKSource Holding sp. z o.o. All rights reserved.
 * For licensing, see LICENSE.md.
 */
export declare class CKEditorModule {
}
export * from './ckeditor';
export { CKEditorComponent } from './ckeditor.component';
Comandeer commented 1 year ago

@henkkelder, ok, thanks, now I see the issue. We will look into it.

jacekbogdanski commented 1 year ago

@henkkelder it looks like our building/publishing environment tricked us a bit this time and used the wrong dependencies for the bundle package. We are going to release a patch fix soon to address that issue. I apologise for the inconvenience!

jacekbogdanski commented 1 year ago

@henkkelder we fixed the issue with a quick 4.0.1 hotfix. It can be confirmed by opening this demo sample that uses Angular v16 - https://codesandbox.io/p/sandbox/winter-leaf-878tn5